relay_server/utils/

rate_limits.rs

use std::fmt::{self, Write};
use std::future::Future;
use std::marker::PhantomData;

use relay_profiling::ProfileType;
use relay_quotas::{
    DataCategory, ItemScoping, QuotaScope, RateLimit, RateLimitScope, RateLimits, ReasonCode,
    Scoping,
};
use smallvec::SmallVec;

use crate::envelope::{AttachmentParentType, AttachmentType, Envelope, Item, ItemType};
use crate::integrations::Integration;
use crate::managed::Managed;
use crate::services::outcome::Outcome;

/// Name of the rate limits header.
pub const RATE_LIMITS_HEADER: &str = "X-Sentry-Rate-Limits";

/// Formats the `X-Sentry-Rate-Limits` header.
pub fn format_rate_limits(rate_limits: &RateLimits) -> String {
    let mut header = String::new();

    for rate_limit in rate_limits {
        if !header.is_empty() {
            header.push_str(", ");
        }

        write!(header, "{}:", rate_limit.retry_after.remaining_seconds()).ok();

        for (index, category) in rate_limit.categories.iter().enumerate() {
            if index > 0 {
                header.push(';');
            }
            write!(header, "{category}").ok();
        }

        write!(header, ":{}", rate_limit.scope.name()).ok();

        if let Some(ref reason_code) = rate_limit.reason_code {
            write!(header, ":{reason_code}").ok();
        } else if !rate_limit.namespaces.is_empty() {
            write!(header, ":").ok(); // delimits the empty reason code for namespaces
        }

        for (index, namespace) in rate_limit.namespaces.iter().enumerate() {
            header.push(if index == 0 { ':' } else { ';' });
            write!(header, "{namespace}").ok();
        }
    }

    header
}

/// Parses the `X-Sentry-Rate-Limits` header.
pub fn parse_rate_limits(scoping: &Scoping, string: &str) -> RateLimits {
    let mut rate_limits = RateLimits::new();

    for limit in string.split(',') {
        let limit = limit.trim();
        if limit.is_empty() {
            continue;
        }

        let mut components = limit.split(':');

        let retry_after = match components.next().and_then(|s| s.parse().ok()) {
            Some(retry_after) => retry_after,
            None => continue,
        };

        let categories = components
            .next()
            .unwrap_or("")
            .split(';')
            .filter(|category| !category.is_empty())
            .map(DataCategory::from_name)
            .collect();

        let quota_scope = QuotaScope::from_name(components.next().unwrap_or(""));
        let scope = RateLimitScope::for_quota(scoping, quota_scope);

        let reason_code = components
            .next()
            .filter(|s| !s.is_empty())
            .map(ReasonCode::new);

        let namespace = components
            .next()
            .unwrap_or("")
            .split(';')
            .filter(|s| !s.is_empty())
            .filter_map(|s| s.parse().ok())
            .collect();

        rate_limits.add(RateLimit {
            categories,
            scope,
            reason_code,
            retry_after,
            namespaces: namespace,
        });
    }

    rate_limits
}

/// Infer the data category from an item.
///
/// Categories depend mostly on the item type, with a few special cases:
/// - `Event`: the category is inferred from the event type. This requires the `event_type` header
///   to be set on the event item.
/// - `Attachment`: If the attachment creates an event (e.g. for minidumps), the category is assumed
///   to be `Error`.
fn infer_event_category(item: &Item) -> Option<DataCategory> {
    match item.ty() {
        ItemType::Event => Some(DataCategory::Error),
        ItemType::Transaction => Some(DataCategory::Transaction),
        ItemType::Security | ItemType::RawSecurity => Some(DataCategory::Security),
        ItemType::UnrealReport => Some(DataCategory::Error),
        ItemType::UserReportV2 => Some(DataCategory::UserReportV2),
        ItemType::Attachment if item.creates_event() => Some(DataCategory::Error),
        ItemType::Attachment => None,
        ItemType::Session => None,
        ItemType::Sessions => None,
        ItemType::MetricBuckets => None,
        ItemType::FormData => None,
        ItemType::UserReport => None,
        ItemType::Profile => None,
        ItemType::ReplayEvent => None,
        ItemType::ReplayRecording => None,
        ItemType::ReplayVideo => None,
        ItemType::ClientReport => None,
        ItemType::CheckIn => None,
        ItemType::Log => None,
        ItemType::TraceMetric => None,
        ItemType::Span => None,
        ItemType::ProfileChunk => None,
        ItemType::Integration => None,
        ItemType::Unknown(_) => None,
    }
}

/// Quantity metrics for a single category of attachments.
///
/// Tracks both the count of attachments and size in bytes.
#[derive(Clone, Copy, Debug, Default)]
pub struct AttachmentQuantity {
    /// Number of attachment items.
    pub count: usize,
    /// Total size of attachments in bytes.
    pub bytes: usize,
}

impl AttachmentQuantity {
    pub fn is_empty(&self) -> bool {
        self.count == 0 && self.bytes == 0
    }
}

/// Aggregated attachment quantities grouped by [`AttachmentParentType`].
///
/// This separation is necessary since rate limiting logic varies by [`AttachmentParentType`].
#[derive(Clone, Copy, Debug, Default)]
pub struct AttachmentQuantities {
    /// Quantities of Event Attachments.
    ///
    /// See also: [`AttachmentParentType::Event`].
    pub event: AttachmentQuantity,
    /// Quantities of trace V2 Attachments.
    pub trace: AttachmentQuantity,
    /// Quantities of span V2 Attachments.
    pub span: AttachmentQuantity,
}

impl AttachmentQuantities {
    /// Returns the total count of all attachments across all parent types.
    pub fn count(&self) -> usize {
        let AttachmentQuantities { event, trace, span } = self;
        event.count + trace.count + span.count
    }

    /// Returns the total size in bytes of all attachments across all parent types.
    pub fn bytes(&self) -> usize {
        let AttachmentQuantities { event, trace, span } = self;
        event.bytes + trace.bytes + span.bytes
    }
}

/// Collection of all transaction profile quantities.
#[derive(Clone, Copy, Debug, Default)]
pub struct ProfileQuantities {
    /// All transaction profiles in the backend category.
    pub backend: usize,
    /// All transaction profiles in the ui category.
    pub ui: usize,
    /// All transaction profiles, includes profiles in the backend and ui categories as well as
    /// profiles which are in neither category.
    pub total: usize,
}

/// A summary of `Envelope` contents.
///
/// Summarizes the contained event, size of attachments, session updates, and whether there are
/// plain attachments. This is used for efficient rate limiting or outcome handling.
#[non_exhaustive]
#[derive(Clone, Copy, Debug, Default)]
pub struct EnvelopeSummary {
    /// The data category of the event in the envelope. `None` if there is no event.
    pub event_category: Option<DataCategory>,

    /// The quantities of all attachments combined.
    pub attachment_quantities: AttachmentQuantities,

    /// The number of all session updates.
    pub session_quantity: usize,

    /// The number of profiles.
    pub profile_quantity: ProfileQuantities,

    /// The number of replays.
    pub replay_quantity: usize,

    /// The number of user reports (legacy item type for user feedback).
    pub user_report_quantity: usize,

    /// The number of monitor check-ins.
    pub monitor_quantity: usize,

    /// The number of log for the log product sent.
    pub log_item_quantity: usize,

    /// The number of log bytes for the log product sent, in bytes
    pub log_byte_quantity: usize,

    /// Secondary number of transactions.
    ///
    /// This is 0 for envelopes which contain a transaction,
    /// only secondary transaction quantity should be tracked here,
    /// these are for example transaction counts extracted from metrics.
    ///
    /// A "primary" transaction is contained within the envelope,
    /// marking the envelope data category a [`DataCategory::Transaction`].
    pub secondary_transaction_quantity: usize,

    /// See `secondary_transaction_quantity`.
    pub secondary_span_quantity: usize,

    /// The number of standalone spans.
    pub span_quantity: usize,

    /// Indicates that the envelope contains regular attachments that do not create event payloads.
    pub has_plain_attachments: bool,

    /// The payload size of this envelope.
    pub payload_size: usize,

    /// The number of profile chunks in this envelope.
    pub profile_chunk_quantity: usize,
    /// The number of UI profile chunks in this envelope.
    pub profile_chunk_ui_quantity: usize,

    /// The number of trace metrics in this envelope.
    pub trace_metric_quantity: usize,

    /// The number of trace metric bytes in this envelope.
    pub trace_metric_byte_quantity: usize,
}

impl EnvelopeSummary {
    /// Creates an empty summary.
    pub fn empty() -> Self {
        Self::default()
    }

    /// Creates an envelope summary and aggregates the given envelope.
    pub fn compute(envelope: &Envelope) -> Self {
        Self::compute_items(envelope.items())
    }

    pub fn compute_items<'a>(items: impl IntoIterator<Item = &'a Item>) -> Self {
        let mut summary = Self::empty();

        for item in items {
            if item.creates_event() {
                summary.infer_category(item);
            } else if item.ty() == &ItemType::Attachment {
                // Plain attachments do not create events.
                summary.has_plain_attachments = true;
            }

            // If the item has been rate limited before, the quota has been consumed and outcomes
            // emitted. We can skip it here.
            if item.rate_limited() {
                continue;
            }

            if let Some(source_quantities) = item.source_quantities() {
                summary.secondary_transaction_quantity += source_quantities.transactions;
                summary.secondary_span_quantity += source_quantities.spans;
            }

            summary.payload_size += item.len();

            summary.add_quantities(item);

            // Special case since v1 and v2 share a data category.
            // Adding this in add_quantity would include v2 in the count.
            if item.ty() == &ItemType::UserReport {
                summary.user_report_quantity += 1;
            }
        }

        summary
    }

    fn add_quantities(&mut self, item: &Item) {
        // The Nintendo switch item is a special case which should've been modelled like the
        // `Unreal4Context` as potentially a separate item type which does not have its own data
        // category.
        //
        // Currently there is no outcome category for this item, as it will be dissolved into
        // multiple different items once processed.
        if item.attachment_type() == Some(AttachmentType::NintendoSwitchDyingMessage) {
            return;
        }

        for (category, quantity) in item.quantities() {
            let target_quantity = match category {
                DataCategory::Attachment => match item.attachment_parent_type() {
                    AttachmentParentType::Span => &mut self.attachment_quantities.span.bytes,
                    AttachmentParentType::Trace => &mut self.attachment_quantities.trace.bytes,
                    AttachmentParentType::Event => &mut self.attachment_quantities.event.bytes,
                },
                DataCategory::AttachmentItem => match item.attachment_parent_type() {
                    AttachmentParentType::Span => &mut self.attachment_quantities.span.count,
                    AttachmentParentType::Trace => &mut self.attachment_quantities.trace.count,
                    AttachmentParentType::Event => &mut self.attachment_quantities.event.count,
                },
                DataCategory::Session => &mut self.session_quantity,
                DataCategory::Profile => &mut self.profile_quantity.total,
                DataCategory::ProfileBackend => &mut self.profile_quantity.backend,
                DataCategory::ProfileUi => &mut self.profile_quantity.ui,
                DataCategory::Replay => &mut self.replay_quantity,
                DataCategory::DoNotUseReplayVideo => &mut self.replay_quantity,
                DataCategory::Monitor => &mut self.monitor_quantity,
                DataCategory::Span => &mut self.span_quantity,
                DataCategory::TraceMetric => &mut self.trace_metric_quantity,
                DataCategory::TraceMetricByte => &mut self.trace_metric_byte_quantity,
                DataCategory::LogItem => &mut self.log_item_quantity,
                DataCategory::LogByte => &mut self.log_byte_quantity,
                DataCategory::ProfileChunk => &mut self.profile_chunk_quantity,
                DataCategory::ProfileChunkUi => &mut self.profile_chunk_ui_quantity,
                // TODO: This catch-all looks dangerous
                _ => continue,
            };
            *target_quantity += quantity;
        }
    }

    /// Infers the appropriate [`DataCategory`] for the envelope [`Item`].
    ///
    /// The inferred category is only applied to the [`EnvelopeSummary`] if there is not yet
    /// a category set.
    fn infer_category(&mut self, item: &Item) {
        if matches!(self.event_category, None | Some(DataCategory::Default))
            && let Some(category) = infer_event_category(item)
        {
            self.event_category = Some(category);
        }
    }

    /// Returns `true` if the envelope contains items that depend on spans.
    ///
    /// This is used to determined if we should be checking span quota, as the quota should be
    /// checked both if there are spans or if there are span dependent items (e.g. span attachments).
    pub fn has_span_dependent_items(&self) -> bool {
        !self.attachment_quantities.span.is_empty()
    }
}

/// Rate limiting information for a data category.
#[derive(Debug, Default, PartialEq)]
#[cfg_attr(test, derive(Clone))]
pub struct CategoryLimit {
    /// The limited data category.
    category: Option<DataCategory>,
    /// Additional and optional data categories in which outcomes will be produced.
    extra_outcome_categories: SmallVec<[DataCategory; 1]>,
    /// The total rate limited quantity across all items.
    ///
    /// This will be `0` if nothing was rate limited.
    quantity: usize,
    /// The reason code of the applied rate limit.
    ///
    /// Defaults to `None` if the quota does not declare a reason code.
    reason_code: Option<ReasonCode>,
}

impl CategoryLimit {
    /// Creates a new `CategoryLimit`.
    ///
    /// Returns an inactive limit if `rate_limit` is `None`.
    fn new(category: DataCategory, quantity: usize, rate_limit: Option<&RateLimit>) -> Self {
        match rate_limit {
            Some(limit) => Self {
                category: Some(category),
                quantity,
                extra_outcome_categories: Default::default(),
                reason_code: limit.reason_code.clone(),
            },
            None => Self::default(),
        }
    }

    /// Adds an additional outcome in the specified category to the limit.
    pub fn add_outcome_category(mut self, category: DataCategory) -> Self {
        self.extra_outcome_categories.push(category);
        self
    }

    /// Recreates the category limit, if active, for a new category with the same reason.
    pub fn clone_for(&self, category: DataCategory, quantity: usize) -> CategoryLimit {
        if !self.is_active() {
            return Self::default();
        }

        Self {
            category: Some(category),
            extra_outcome_categories: Default::default(),
            quantity,
            reason_code: self.reason_code.clone(),
        }
    }

    /// Returns `true` if this is an active limit.
    ///
    /// Inactive limits are placeholders with no category set.
    pub fn is_active(&self) -> bool {
        self.category.is_some()
    }

    fn outcomes(self) -> impl Iterator<Item = (Outcome, DataCategory, usize)> {
        let Self {
            category,
            extra_outcome_categories,
            quantity,
            reason_code,
        } = self;

        if category.is_none() || quantity == 0 {
            return either::Either::Left(std::iter::empty());
        }

        let outcomes = std::iter::chain(category, extra_outcome_categories).map(move |category| {
            (
                Outcome::RateLimited(reason_code.clone()),
                category,
                quantity,
            )
        });

        either::Either::Right(outcomes)
    }
}

/// Rate limiting information for a single category of attachments.
#[derive(Default, Debug)]
#[cfg_attr(test, derive(Clone))]
pub struct AttachmentLimits {
    /// Rate limit applied to attachment bytes ([`DataCategory::Attachment`]).
    pub bytes: CategoryLimit,
    /// Rate limit applied to attachment item count ([`DataCategory::AttachmentItem`]).
    pub count: CategoryLimit,
}

impl AttachmentLimits {
    fn is_active(&self) -> bool {
        self.bytes.is_active() || self.count.is_active()
    }
}

/// Rate limiting information for attachments grouped by [`AttachmentParentType`].
///
/// See [`AttachmentQuantities`] for the corresponding quantity tracking.
#[derive(Default, Debug)]
#[cfg_attr(test, derive(Clone))]
pub struct AttachmentsLimits {
    /// Limits for V1 Attachments.
    pub event: AttachmentLimits,
    /// Limits for trace V2 Attachments.
    pub trace: AttachmentLimits,
    /// Limits for span V2 Attachments.
    pub span: AttachmentLimits,
}

/// Information on the limited quantities returned by [`EnvelopeLimiter::compute`].
#[derive(Default, Debug)]
#[cfg_attr(test, derive(Clone))]
pub struct Enforcement {
    /// The event item rate limit.
    pub event: CategoryLimit,
    /// The rate limit for the indexed category of the event.
    pub event_indexed: CategoryLimit,
    /// The attachments limits
    pub attachments_limits: AttachmentsLimits,
    /// The combined session item rate limit.
    pub sessions: CategoryLimit,
    /// The combined transaction profile item rate limits, for all transaction profiles.
    ///
    /// This is at least the sum of [`Self::profiles_backend`] and [`Self::profiles_ui`],
    /// potentially more if there are profiles without a known platform.
    pub profiles: CategoryLimit,
    /// The combined backend transaction profile item rate limit.
    pub profiles_backend: CategoryLimit,
    /// The combined ui transaction profile item rate limit.
    pub profiles_ui: CategoryLimit,
    /// The rate limit for the indexed profiles category.
    pub profiles_indexed: CategoryLimit,
    /// The combined replay item rate limit.
    pub replays: CategoryLimit,
    /// The combined check-in item rate limit.
    pub check_ins: CategoryLimit,
    /// The combined logs (our product logs) rate limit.
    pub log_items: CategoryLimit,
    /// The combined logs (our product logs) rate limit.
    pub log_bytes: CategoryLimit,
    /// The combined spans rate limit.
    pub spans: CategoryLimit,
    /// The rate limit for the indexed span category.
    pub spans_indexed: CategoryLimit,
    /// The rate limit for user report v1.
    pub user_reports: CategoryLimit,
    /// The combined profile chunk item rate limit.
    pub profile_chunks: CategoryLimit,
    /// The combined profile chunk ui item rate limit.
    pub profile_chunks_ui: CategoryLimit,
    /// The combined trace metric item rate limit.
    pub trace_metrics: CategoryLimit,
    /// The combined trace metric byte rate limit.
    pub trace_metrics_bytes: CategoryLimit,
}

impl Enforcement {
    /// Returns the `CategoryLimit` for the event.
    ///
    /// `None` if the event is not rate limited.
    pub fn active_event(&self) -> Option<&CategoryLimit> {
        if self.event.is_active() {
            Some(&self.event)
        } else if self.event_indexed.is_active() {
            Some(&self.event_indexed)
        } else {
            None
        }
    }

    /// Returns `true` if the event is rate limited.
    pub fn is_event_active(&self) -> bool {
        self.active_event().is_some()
    }

    /// Helper for `track_outcomes`.
    fn get_outcomes(self) -> impl Iterator<Item = (Outcome, DataCategory, usize)> {
        let Self {
            event,
            event_indexed,
            attachments_limits:
                AttachmentsLimits {
                    event:
                        AttachmentLimits {
                            bytes: event_attachment_bytes,
                            count: event_attachment_item,
                        },
                    trace:
                        AttachmentLimits {
                            bytes: trace_attachment_bytes,
                            count: trace_attachment_item,
                        },
                    span:
                        AttachmentLimits {
                            bytes: span_attachment_bytes,
                            count: span_attachment_item,
                        },
                },
            sessions: _, // Do not report outcomes for sessions.
            profiles,
            profiles_backend,
            profiles_ui,
            profiles_indexed,
            replays,
            check_ins,
            log_items,
            log_bytes,
            spans,
            spans_indexed,
            user_reports,
            profile_chunks,
            profile_chunks_ui,
            trace_metrics,
            trace_metrics_bytes,
        } = self;

        let limits = [
            event,
            event_indexed,
            event_attachment_bytes,
            event_attachment_item,
            trace_attachment_bytes,
            trace_attachment_item,
            span_attachment_bytes,
            span_attachment_item,
            profiles,
            profiles_backend,
            profiles_ui,
            profiles_indexed,
            replays,
            check_ins,
            log_items,
            log_bytes,
            spans,
            spans_indexed,
            user_reports,
            profile_chunks,
            profile_chunks_ui,
            trace_metrics,
            trace_metrics_bytes,
        ];

        limits.into_iter().flat_map(|limit| limit.outcomes())
    }

    /// Applies the [`Enforcement`] on the [`Envelope`] by removing all items that were rate limited
    /// and emits outcomes for each rate limited category.
    ///
    /// # Example
    ///
    /// ## Interaction between Events and Attachments
    ///
    /// An envelope with an `Error` event and an `Attachment`. Two quotas specify to drop all
    /// attachments (reason `"a"`) and all errors (reason `"e"`). The result of enforcement will be:
    ///
    /// 1. All items are removed from the envelope.
    /// 2. Enforcements report both the event and the attachment dropped with reason `"e"`, since
    ///    dropping an event automatically drops all attachments with the same reason.
    /// 3. Rate limits report the single event limit `"e"`, since attachment limits do not need to
    ///    be checked in this case.
    ///
    /// ## Required Attachments
    ///
    /// An envelope with a single Minidump `Attachment`, and a single quota specifying to drop all
    /// attachments with reason `"a"`:
    ///
    /// 1. Since the minidump creates an event and is required for processing, it remains in the
    ///    envelope and is marked as `rate_limited`.
    /// 2. Enforcements report the attachment dropped with reason `"a"`.
    /// 3. Rate limits are empty since it is allowed to send required attachments even when rate
    ///    limited.
    ///
    /// ## Previously Rate Limited Attachments
    ///
    /// An envelope with a single item marked as `rate_limited`, and a quota specifying to drop
    /// everything with reason `"d"`:
    ///
    /// 1. The item remains in the envelope.
    /// 2. Enforcements are empty. Rate limiting has occurred at an earlier stage in the pipeline.
    /// 3. Rate limits are empty.
    pub fn apply_to_managed(self, envelope: &mut Managed<Box<Envelope>>) {
        envelope.modify(|envelope, records| {
            envelope.retain_items(|item| self.retain_item(item));

            // Sessions currently do not emit any outcomes, but may be dropped.
            records.lenient(DataCategory::Session);
            // This is an existing bug in how user reports handle rate limits and emit outcomes.
            //
            // User report v1 and v2 (feedback) are counting into the same category, but that is not
            // completely consistent leading to some mismatches when emitting outcomes from rate
            // limiting vs how outcomes are counted on the `Managed` instance.
            //
            // Issue: <https://github.com/getsentry/relay/issues/5524>.
            records.lenient(DataCategory::UserReportV2);

            for (outcome, category, quantity) in self.get_outcomes() {
                records.reject_err(outcome, (category, quantity))
            }
        });
    }

    /// Returns `true` when an [`Item`] can be retained, `false` otherwise.
    fn retain_item(&self, item: &mut Item) -> bool {
        // Remove event items and all items that depend on this event
        if self.event.is_active() && item.requires_event() {
            return false;
        }

        // When checking limits for categories that have an indexed variant,
        // we only have to check the more specific, the indexed, variant
        // to determine whether an item is limited.
        match item.ty() {
            ItemType::Attachment => {
                match item.attachment_parent_type() {
                    AttachmentParentType::Span => !self.attachments_limits.span.is_active(),
                    AttachmentParentType::Trace => !self.attachments_limits.trace.is_active(),
                    AttachmentParentType::Event => {
                        if !self.attachments_limits.event.is_active() {
                            return true;
                        }
                        if item.creates_event() {
                            item.set_rate_limited(true);
                            true
                        } else {
                            false
                        }
                    }
                }
            }
            ItemType::Session => !self.sessions.is_active(),
            ItemType::Profile => {
                if self.profiles_indexed.is_active() {
                    false
                } else if let Some(platform) = item.profile_type() {
                    match platform {
                        ProfileType::Backend => !self.profiles_backend.is_active(),
                        ProfileType::Ui => !self.profiles_ui.is_active(),
                    }
                } else {
                    true
                }
            }
            ItemType::ReplayEvent => !self.replays.is_active(),
            ItemType::ReplayVideo => !self.replays.is_active(),
            ItemType::ReplayRecording => !self.replays.is_active(),
            ItemType::UserReport => !self.user_reports.is_active(),
            ItemType::CheckIn => !self.check_ins.is_active(),
            ItemType::Log => {
                !(self.log_items.is_active() || self.log_bytes.is_active())
            }
            ItemType::Span => !self.spans_indexed.is_active(),
            ItemType::ProfileChunk => match item.profile_type() {
                Some(ProfileType::Backend) => !self.profile_chunks.is_active(),
                Some(ProfileType::Ui) => !self.profile_chunks_ui.is_active(),
                None => true,
            },
            ItemType::TraceMetric => !(self.trace_metrics.is_active() || self.trace_metrics_bytes.is_active()),
            ItemType::Integration => match item.integration() {
                Some(Integration::Logs(_)) => !(self.log_items.is_active() || self.log_bytes.is_active()),
                Some(Integration::Spans(_)) => !self.spans_indexed.is_active(),
                None => true,
            },
            ItemType::Event
            | ItemType::Transaction
            | ItemType::Security
            | ItemType::FormData
            | ItemType::RawSecurity
            | ItemType::UnrealReport
            | ItemType::Sessions
            | ItemType::MetricBuckets
            | ItemType::ClientReport
            | ItemType::UserReportV2  // This is an event type.
            | ItemType::Unknown(_) => true,
        }
    }
}

/// Which limits to check with the [`EnvelopeLimiter`].
#[derive(Debug, Copy, Clone)]
pub enum CheckLimits {
    /// Checks all limits except indexed categories.
    ///
    /// In the fast path it is necessary to apply cached rate limits but to not enforce indexed rate limits.
    /// Because at the time of the check the decision whether an envelope is sampled or not is not yet known.
    /// Additionally even if the item is later dropped by dynamic sampling, it must still be around to extract metrics
    /// and cannot be dropped too early.
    NonIndexed,
}

struct Check<F, E, R> {
    limits: CheckLimits,
    check: F,
    _1: PhantomData<E>,
    _2: PhantomData<R>,
}

impl<F, E, R> Check<F, E, R>
where
    F: FnMut(ItemScoping, usize) -> R,
    R: Future<Output = Result<RateLimits, E>>,
{
    async fn apply(&mut self, scoping: ItemScoping, quantity: usize) -> Result<RateLimits, E> {
        if matches!(self.limits, CheckLimits::NonIndexed) && scoping.category.is_indexed() {
            return Ok(RateLimits::default());
        }

        (self.check)(scoping, quantity).await
    }
}

/// Enforces rate limits with the given `check` function on items in the envelope.
///
/// The `check` function is called with the following rules:
///  - Once for a single event, if present in the envelope.
///  - Once for all comprised attachments, unless the event was rate limited.
///  - Once for all comprised sessions.
///
/// Items violating the rate limit are removed from the envelope. This follows a set of rules:
///  - If the event is removed, all items depending on the event are removed (e.g. attachments).
///  - Attachments are not removed if they create events (e.g. minidumps).
///  - Sessions are handled separately from all of the above.
pub struct EnvelopeLimiter<F, E, R> {
    check: Check<F, E, R>,
    event_category: Option<DataCategory>,
}

impl<'a, F, E, R> EnvelopeLimiter<F, E, R>
where
    F: FnMut(ItemScoping, usize) -> R,
    R: Future<Output = Result<RateLimits, E>>,
{
    /// Create a new `EnvelopeLimiter` with the given `check` function.
    pub fn new(limits: CheckLimits, check: F) -> Self {
        Self {
            check: Check {
                check,
                limits,
                _1: PhantomData,
                _2: PhantomData,
            },
            event_category: None,
        }
    }

    /// Process rate limits for the envelope, returning applied limits.
    ///
    /// Returns a tuple of `Enforcement` and `RateLimits`:
    ///
    /// - Enforcements declare the quantities of categories that have been rate limited with the
    ///   individual reason codes that caused rate limiting. If multiple rate limits applied to a
    ///   category, then the longest limit is reported.
    /// - Rate limits declare all active rate limits, regardless of whether they have been applied
    ///   to items in the envelope. This excludes rate limits applied to required attachments, since
    ///   clients are allowed to continue sending them.
    pub async fn compute(
        mut self,
        envelope: &Envelope,
        scoping: &'a Scoping,
    ) -> Result<(Enforcement, RateLimits), E> {
        let mut summary = EnvelopeSummary::compute(envelope);
        summary.event_category = self.event_category.or(summary.event_category);

        let (enforcement, rate_limits) = self.execute(&summary, scoping).await?;
        Ok((enforcement, rate_limits))
    }

    async fn execute(
        &mut self,
        summary: &EnvelopeSummary,
        scoping: &'a Scoping,
    ) -> Result<(Enforcement, RateLimits), E> {
        let mut rate_limits = RateLimits::new();
        let mut enforcement = Enforcement::default();

        // Handle event.
        if let Some(category) = summary.event_category {
            // Check the broad category for limits.
            let mut event_limits = self.check.apply(scoping.item(category), 1).await?;
            enforcement.event = CategoryLimit::new(category, 1, event_limits.longest());

            if let Some(index_category) = category.index_category() {
                // Check the specific/indexed category for limits only if the specific one has not already
                // an enforced limit.
                if event_limits.is_empty() {
                    event_limits.merge(self.check.apply(scoping.item(index_category), 1).await?);
                }

                enforcement.event_indexed =
                    CategoryLimit::new(index_category, 1, event_limits.longest());
            };

            rate_limits.merge(event_limits);
        }

        // Handle spans.
        if enforcement.is_event_active() {
            enforcement.spans = enforcement
                .event
                .clone_for(DataCategory::Span, summary.span_quantity);

            enforcement.spans_indexed = enforcement
                .event_indexed
                .clone_for(DataCategory::SpanIndexed, summary.span_quantity);
        } else if summary.span_quantity > 0 || summary.has_span_dependent_items() {
            let mut span_limits = self
                .check
                .apply(scoping.item(DataCategory::Span), summary.span_quantity)
                .await?;
            enforcement.spans = CategoryLimit::new(
                DataCategory::Span,
                summary.span_quantity,
                span_limits.longest(),
            );

            if span_limits.is_empty() {
                span_limits.merge(
                    self.check
                        .apply(
                            scoping.item(DataCategory::SpanIndexed),
                            summary.span_quantity,
                        )
                        .await?,
                );
            }

            enforcement.spans_indexed = CategoryLimit::new(
                DataCategory::SpanIndexed,
                summary.span_quantity,
                span_limits.longest(),
            );

            rate_limits.merge(span_limits);
        }

        // Handle span attachments
        if enforcement.spans_indexed.is_active() {
            enforcement.attachments_limits.span.bytes = enforcement.spans_indexed.clone_for(
                DataCategory::Attachment,
                summary.attachment_quantities.span.bytes,
            );
            enforcement.attachments_limits.span.count = enforcement.spans_indexed.clone_for(
                DataCategory::AttachmentItem,
                summary.attachment_quantities.span.count,
            );
        } else if !summary.attachment_quantities.span.is_empty() {
            // While we could combine this check with the check that we do for event and trace
            // attachments, this would complicate the logic so we opted against doing that.
            // In practice the performance impact should be negligible since different types
            // of attachments should rarely be send together.
            enforcement.attachments_limits.span = self
                .check_attachment_limits(scoping, &summary.attachment_quantities.span)
                .await?;
        }

        // Handle attachments.
        if let Some(limit) = enforcement.active_event() {
            let limit1 = limit.clone_for(
                DataCategory::Attachment,
                summary.attachment_quantities.event.bytes,
            );
            let limit2 = limit.clone_for(
                DataCategory::AttachmentItem,
                summary.attachment_quantities.event.count,
            );

            enforcement.attachments_limits.event.bytes = limit1;
            enforcement.attachments_limits.event.count = limit2;
        } else {
            let mut attachment_limits = RateLimits::new();
            if summary.attachment_quantities.event.bytes > 0 {
                let item_scoping = scoping.item(DataCategory::Attachment);

                let attachment_byte_limits = self
                    .check
                    .apply(item_scoping, summary.attachment_quantities.event.bytes)
                    .await?;

                enforcement.attachments_limits.event.bytes = CategoryLimit::new(
                    DataCategory::Attachment,
                    summary.attachment_quantities.event.bytes,
                    attachment_byte_limits.longest(),
                );
                enforcement.attachments_limits.event.count =
                    enforcement.attachments_limits.event.bytes.clone_for(
                        DataCategory::AttachmentItem,
                        summary.attachment_quantities.event.count,
                    );
                attachment_limits.merge(attachment_byte_limits);
            }
            if !attachment_limits.is_limited() && summary.attachment_quantities.event.count > 0 {
                let item_scoping = scoping.item(DataCategory::AttachmentItem);

                let attachment_item_limits = self
                    .check
                    .apply(item_scoping, summary.attachment_quantities.event.count)
                    .await?;

                enforcement.attachments_limits.event.count = CategoryLimit::new(
                    DataCategory::AttachmentItem,
                    summary.attachment_quantities.event.count,
                    attachment_item_limits.longest(),
                );
                enforcement.attachments_limits.event.bytes =
                    enforcement.attachments_limits.event.count.clone_for(
                        DataCategory::Attachment,
                        summary.attachment_quantities.event.bytes,
                    );
                attachment_limits.merge(attachment_item_limits);
            }

            // Only record rate limits for plain attachments. For all other attachments, it's
            // perfectly "legal" to send them. They will still be discarded in Sentry, but clients
            // can continue to send them.
            if summary.has_plain_attachments {
                rate_limits.merge(attachment_limits);
            }
        }

        // Handle trace attachments.
        if !summary.attachment_quantities.trace.is_empty() {
            enforcement.attachments_limits.trace = self
                .check_attachment_limits(scoping, &summary.attachment_quantities.trace)
                .await?;
        }

        // Handle sessions.
        if summary.session_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::Session);
            let session_limits = self
                .check
                .apply(item_scoping, summary.session_quantity)
                .await?;
            enforcement.sessions = CategoryLimit::new(
                DataCategory::Session,
                summary.session_quantity,
                session_limits.longest(),
            );
            rate_limits.merge(session_limits);
        }

        // Handle trace metrics.
        let mut trace_metric_limits = RateLimits::new();
        if summary.trace_metric_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::TraceMetric);
            trace_metric_limits = self
                .check
                .apply(item_scoping, summary.trace_metric_quantity)
                .await?;
            enforcement.trace_metrics = CategoryLimit::new(
                DataCategory::TraceMetric,
                summary.trace_metric_quantity,
                trace_metric_limits.longest(),
            );
            enforcement.trace_metrics_bytes = CategoryLimit::new(
                DataCategory::TraceMetricByte,
                summary.trace_metric_byte_quantity,
                trace_metric_limits.longest(),
            );
        }
        if !trace_metric_limits.is_limited() && summary.trace_metric_byte_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::TraceMetricByte);
            trace_metric_limits = self
                .check
                .apply(item_scoping, summary.trace_metric_byte_quantity)
                .await?;
            enforcement.trace_metrics = CategoryLimit::new(
                DataCategory::TraceMetric,
                summary.trace_metric_quantity,
                trace_metric_limits.longest(),
            );
            enforcement.trace_metrics_bytes = CategoryLimit::new(
                DataCategory::TraceMetricByte,
                summary.trace_metric_byte_quantity,
                trace_metric_limits.longest(),
            );
        }
        rate_limits.merge(trace_metric_limits);

        // Handle logs.
        let mut log_limits = RateLimits::new();
        if summary.log_item_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::LogItem);
            log_limits = self
                .check
                .apply(item_scoping, summary.log_item_quantity)
                .await?;
            enforcement.log_bytes = CategoryLimit::new(
                DataCategory::LogByte,
                summary.log_byte_quantity,
                log_limits.longest(),
            );
            enforcement.log_items = CategoryLimit::new(
                DataCategory::LogItem,
                summary.log_item_quantity,
                log_limits.longest(),
            );
        }
        if !log_limits.is_limited() && summary.log_byte_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::LogByte);
            log_limits = self
                .check
                .apply(item_scoping, summary.log_byte_quantity)
                .await?;
            enforcement.log_bytes = CategoryLimit::new(
                DataCategory::LogByte,
                summary.log_byte_quantity,
                log_limits.longest(),
            );
            enforcement.log_items = CategoryLimit::new(
                DataCategory::LogItem,
                summary.log_item_quantity,
                log_limits.longest(),
            );
        }
        rate_limits.merge(log_limits);

        // Handle profiles.
        if enforcement.is_event_active() {
            enforcement.profiles = enforcement
                .event
                .clone_for(DataCategory::Profile, summary.profile_quantity.total);
            enforcement.profiles_indexed = enforcement
                .event_indexed
                .clone_for(DataCategory::ProfileIndexed, summary.profile_quantity.total);

            enforcement.profiles_backend = enforcement.event.clone_for(
                DataCategory::ProfileBackend,
                summary.profile_quantity.backend,
            );
            enforcement.profiles_ui = enforcement
                .event
                .clone_for(DataCategory::ProfileUi, summary.profile_quantity.ui);
        } else if summary.profile_quantity.total > 0 {
            let mut profile_limits = self
                .check
                .apply(
                    scoping.item(DataCategory::Profile),
                    summary.profile_quantity.total,
                )
                .await?;

            // Profiles can persist in envelopes without transaction if the transaction item
            // was dropped by dynamic sampling.
            if profile_limits.is_empty() && summary.event_category.is_none() {
                profile_limits = self
                    .check
                    .apply(scoping.item(DataCategory::Transaction), 0)
                    .await?;
            }

            enforcement.profiles = CategoryLimit::new(
                DataCategory::Profile,
                summary.profile_quantity.total,
                profile_limits.longest(),
            );

            if enforcement.profiles.quantity == 0 {
                if summary.profile_quantity.backend > 0 {
                    let limit = self
                        .check
                        .apply(
                            scoping.item(DataCategory::ProfileBackend),
                            summary.profile_quantity.backend,
                        )
                        .await?;

                    enforcement.profiles_backend = CategoryLimit::new(
                        DataCategory::ProfileBackend,
                        summary.profile_quantity.backend,
                        limit.longest(),
                    )
                    .add_outcome_category(DataCategory::Profile);

                    profile_limits.merge(limit);
                }
                if summary.profile_quantity.ui > 0 {
                    let limit = self
                        .check
                        .apply(
                            scoping.item(DataCategory::ProfileUi),
                            summary.profile_quantity.ui,
                        )
                        .await?;

                    enforcement.profiles_ui = CategoryLimit::new(
                        DataCategory::ProfileUi,
                        summary.profile_quantity.ui,
                        limit.longest(),
                    )
                    .add_outcome_category(DataCategory::Profile);

                    profile_limits.merge(limit);
                }
            } else {
                enforcement.profiles_backend = CategoryLimit::new(
                    DataCategory::ProfileBackend,
                    summary.profile_quantity.backend,
                    profile_limits.longest(),
                );
                enforcement.profiles_ui = CategoryLimit::new(
                    DataCategory::ProfileUi,
                    summary.profile_quantity.ui,
                    profile_limits.longest(),
                );
            }

            if enforcement.profiles.quantity > 0 {
                enforcement.profiles_indexed = enforcement
                    .profiles
                    .clone_for(DataCategory::ProfileIndexed, summary.profile_quantity.total);
            } else {
                let limit = self
                    .check
                    .apply(
                        scoping.item(DataCategory::ProfileIndexed),
                        summary.profile_quantity.total,
                    )
                    .await?;

                if !limit.is_empty() {
                    enforcement.profiles_indexed = CategoryLimit::new(
                        DataCategory::ProfileIndexed,
                        summary.profile_quantity.total,
                        limit.longest(),
                    );

                    profile_limits.merge(limit);
                } else {
                    enforcement.profiles_backend = enforcement
                        .profiles_backend
                        .add_outcome_category(DataCategory::ProfileIndexed);
                    enforcement.profiles_ui = enforcement
                        .profiles_ui
                        .add_outcome_category(DataCategory::ProfileIndexed);
                }
            }

            rate_limits.merge(profile_limits);
        }

        // Handle replays.
        if summary.replay_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::Replay);
            let replay_limits = self
                .check
                .apply(item_scoping, summary.replay_quantity)
                .await?;
            enforcement.replays = CategoryLimit::new(
                DataCategory::Replay,
                summary.replay_quantity,
                replay_limits.longest(),
            );
            rate_limits.merge(replay_limits);
        }

        // Handle user report v1s, which share limits with v2.
        if summary.user_report_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::UserReportV2);
            let user_report_v2_limits = self
                .check
                .apply(item_scoping, summary.user_report_quantity)
                .await?;
            enforcement.user_reports = CategoryLimit::new(
                DataCategory::UserReportV2,
                summary.user_report_quantity,
                user_report_v2_limits.longest(),
            );
            rate_limits.merge(user_report_v2_limits);
        }

        // Handle monitor checkins.
        if summary.monitor_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::Monitor);
            let checkin_limits = self
                .check
                .apply(item_scoping, summary.monitor_quantity)
                .await?;
            enforcement.check_ins = CategoryLimit::new(
                DataCategory::Monitor,
                summary.monitor_quantity,
                checkin_limits.longest(),
            );
            rate_limits.merge(checkin_limits);
        }

        // Handle profile chunks.
        if summary.profile_chunk_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::ProfileChunk);
            let limits = self
                .check
                .apply(item_scoping, summary.profile_chunk_quantity)
                .await?;
            enforcement.profile_chunks = CategoryLimit::new(
                DataCategory::ProfileChunk,
                summary.profile_chunk_quantity,
                limits.longest(),
            );
            rate_limits.merge(limits);
        }

        if summary.profile_chunk_ui_quantity > 0 {
            let item_scoping = scoping.item(DataCategory::ProfileChunkUi);
            let limits = self
                .check
                .apply(item_scoping, summary.profile_chunk_ui_quantity)
                .await?;
            enforcement.profile_chunks_ui = CategoryLimit::new(
                DataCategory::ProfileChunkUi,
                summary.profile_chunk_ui_quantity,
                limits.longest(),
            );
            rate_limits.merge(limits);
        }

        Ok((enforcement, rate_limits))
    }

    async fn check_attachment_limits(
        &mut self,
        scoping: &Scoping,
        quantities: &AttachmentQuantity,
    ) -> Result<AttachmentLimits, E> {
        let mut attachment_limits = self
            .check
            .apply(scoping.item(DataCategory::Attachment), quantities.bytes)
            .await?;

        // Note: The check here is taken from the attachments logic for consistency I think just
        // checking `is_empty` should be fine?
        if !attachment_limits.is_limited() && quantities.count > 0 {
            attachment_limits.merge(
                self.check
                    .apply(scoping.item(DataCategory::AttachmentItem), quantities.count)
                    .await?,
            );
        }

        Ok(AttachmentLimits {
            bytes: CategoryLimit::new(
                DataCategory::Attachment,
                quantities.bytes,
                attachment_limits.longest(),
            ),
            count: CategoryLimit::new(
                DataCategory::AttachmentItem,
                quantities.count,
                attachment_limits.longest(),
            ),
        })
    }
}

impl<F, E, R> fmt::Debug for EnvelopeLimiter<F, E, R> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("EnvelopeLimiter")
            .field("event_category", &self.event_category)
            .finish()
    }
}

#[cfg(test)]
mod tests {

    use std::collections::{BTreeMap, BTreeSet};
    use std::sync::Arc;

    use relay_base_schema::organization::OrganizationId;
    use relay_base_schema::project::{ProjectId, ProjectKey};
    use relay_metrics::MetricNamespace;
    use relay_quotas::RetryAfter;
    use relay_system::Addr;
    use smallvec::smallvec;
    use tokio::sync::Mutex;

    use super::*;
    use crate::envelope::ParentId;
    use crate::{
        envelope::{AttachmentType, ContentType, SourceQuantities},
        extractors::RequestMeta,
    };

    struct RateLimitTestCase {
        name: &'static str,
        denied_categories: &'static [DataCategory],
        expect_attachment_limit_active: bool,
        expected_limiter_calls: &'static [(DataCategory, usize)],
        expected_outcomes: &'static [(DataCategory, usize)],
    }

    #[tokio::test]
    async fn test_format_rate_limits() {
        let mut rate_limits = RateLimits::new();

        // Add a generic rate limit for all categories.
        rate_limits.add(RateLimit {
            categories: Default::default(),
            scope: RateLimitScope::Organization(OrganizationId::new(42)),
            reason_code: Some(ReasonCode::new("my_limit")),
            retry_after: RetryAfter::from_secs(42),
            namespaces: smallvec![],
        });

        // Add a more specific rate limit for just one category.
        rate_limits.add(RateLimit {
            categories: [DataCategory::Transaction, DataCategory::Security].into(),
            scope: RateLimitScope::Project(ProjectId::new(21)),
            reason_code: None,
            retry_after: RetryAfter::from_secs(4711),
            namespaces: smallvec![],
        });

        let formatted = format_rate_limits(&rate_limits);
        let expected = "42::organization:my_limit, 4711:transaction;security:project";
        assert_eq!(formatted, expected);
    }

    #[tokio::test]
    async fn test_format_rate_limits_namespace() {
        let mut rate_limits = RateLimits::new();

        // Rate limit with reason code and namespace.
        rate_limits.add(RateLimit {
            categories: [DataCategory::MetricBucket].into(),
            scope: RateLimitScope::Organization(OrganizationId::new(42)),
            reason_code: Some(ReasonCode::new("my_limit")),
            retry_after: RetryAfter::from_secs(42),
            namespaces: smallvec![MetricNamespace::Transactions, MetricNamespace::Spans],
        });

        // Rate limit without reason code.
        rate_limits.add(RateLimit {
            categories: [DataCategory::MetricBucket].into(),
            scope: RateLimitScope::Organization(OrganizationId::new(42)),
            reason_code: None,
            retry_after: RetryAfter::from_secs(42),
            namespaces: smallvec![MetricNamespace::Spans],
        });

        let formatted = format_rate_limits(&rate_limits);
        let expected = "42:metric_bucket:organization:my_limit:transactions;spans, 42:metric_bucket:organization::spans";
        assert_eq!(formatted, expected);
    }

    #[tokio::test]
    async fn test_parse_invalid_rate_limits() {
        let scoping = Scoping {
            organization_id: OrganizationId::new(42),
            project_id: ProjectId::new(21),
            project_key: ProjectKey::parse("a94ae32be2584e0bbd7a4cbb95971fee").unwrap(),
            key_id: Some(17),
        };

        assert!(parse_rate_limits(&scoping, "").is_ok());
        assert!(parse_rate_limits(&scoping, "invalid").is_ok());
        assert!(parse_rate_limits(&scoping, ",,,").is_ok());
    }

    #[tokio::test]
    async fn test_parse_rate_limits() {
        let scoping = Scoping {
            organization_id: OrganizationId::new(42),
            project_id: ProjectId::new(21),
            project_key: ProjectKey::parse("a94ae32be2584e0bbd7a4cbb95971fee").unwrap(),
            key_id: Some(17),
        };

        // contains "foobar", an unknown scope that should be mapped to Unknown
        let formatted =
            "42::organization:my_limit, invalid, 4711:foobar;transaction;security:project";
        let rate_limits: Vec<RateLimit> =
            parse_rate_limits(&scoping, formatted).into_iter().collect();

        assert_eq!(
            rate_limits,
            vec![
                RateLimit {
                    categories: Default::default(),
                    scope: RateLimitScope::Organization(OrganizationId::new(42)),
                    reason_code: Some(ReasonCode::new("my_limit")),
                    retry_after: rate_limits[0].retry_after,
                    namespaces: smallvec![],
                },
                RateLimit {
                    categories: [
                        DataCategory::Unknown,
                        DataCategory::Transaction,
                        DataCategory::Security,
                    ]
                    .into(),
                    scope: RateLimitScope::Project(ProjectId::new(21)),
                    reason_code: None,
                    retry_after: rate_limits[1].retry_after,
                    namespaces: smallvec![],
                }
            ]
        );

        assert_eq!(42, rate_limits[0].retry_after.remaining_seconds());
        assert_eq!(4711, rate_limits[1].retry_after.remaining_seconds());
    }

    #[tokio::test]
    async fn test_parse_rate_limits_namespace() {
        let scoping = Scoping {
            organization_id: OrganizationId::new(42),
            project_id: ProjectId::new(21),
            project_key: ProjectKey::parse("a94ae32be2584e0bbd7a4cbb95971fee").unwrap(),
            key_id: Some(17),
        };

        let formatted = "42:metric_bucket:organization::transactions;spans";
        let rate_limits: Vec<RateLimit> =
            parse_rate_limits(&scoping, formatted).into_iter().collect();

        assert_eq!(
            rate_limits,
            vec![RateLimit {
                categories: [DataCategory::MetricBucket].into(),
                scope: RateLimitScope::Organization(OrganizationId::new(42)),
                reason_code: None,
                retry_after: rate_limits[0].retry_after,
                namespaces: smallvec![MetricNamespace::Transactions, MetricNamespace::Spans],
            }]
        );
    }

    #[tokio::test]
    async fn test_parse_rate_limits_empty_namespace() {
        let scoping = Scoping {
            organization_id: OrganizationId::new(42),
            project_id: ProjectId::new(21),
            project_key: ProjectKey::parse("a94ae32be2584e0bbd7a4cbb95971fee").unwrap(),
            key_id: Some(17),
        };

        // notice the trailing colon
        let formatted = "42:metric_bucket:organization:some_reason:";
        let rate_limits: Vec<RateLimit> =
            parse_rate_limits(&scoping, formatted).into_iter().collect();

        assert_eq!(
            rate_limits,
            vec![RateLimit {
                categories: [DataCategory::MetricBucket].into(),
                scope: RateLimitScope::Organization(OrganizationId::new(42)),
                reason_code: Some(ReasonCode::new("some_reason")),
                retry_after: rate_limits[0].retry_after,
                namespaces: smallvec![],
            }]
        );
    }

    #[tokio::test]
    async fn test_parse_rate_limits_only_unknown() {
        let scoping = Scoping {
            organization_id: OrganizationId::new(42),
            project_id: ProjectId::new(21),
            project_key: ProjectKey::parse("a94ae32be2584e0bbd7a4cbb95971fee").unwrap(),
            key_id: Some(17),
        };

        let formatted = "42:foo;bar:organization";
        let rate_limits: Vec<RateLimit> =
            parse_rate_limits(&scoping, formatted).into_iter().collect();

        assert_eq!(
            rate_limits,
            vec![RateLimit {
                categories: [DataCategory::Unknown, DataCategory::Unknown].into(),
                scope: RateLimitScope::Organization(OrganizationId::new(42)),
                reason_code: None,
                retry_after: rate_limits[0].retry_after,
                namespaces: smallvec![],
            },]
        );
    }

    macro_rules! envelope {
        ($( $item_type:ident $( :: $attachment_type:ident )? ),*) => {{
            let bytes = "{\"dsn\":\"https://e12d836b15bb49d7bbf99e64295d995b:@sentry.io/42\"}";
            #[allow(unused_mut)]
            let mut envelope = Envelope::parse_bytes(bytes.into()).unwrap();
            $(
                let mut item = Item::new(ItemType::$item_type);
                item.set_payload(ContentType::OctetStream, "0123456789");
                $( item.set_attachment_type(AttachmentType::$attachment_type); )?
                envelope.add_item(item);
            )*

            envelope
        }}
    }

    fn rate_limit(category: DataCategory) -> RateLimit {
        RateLimit {
            categories: [category].into(),
            scope: RateLimitScope::Organization(OrganizationId::new(42)),
            reason_code: None,
            retry_after: RetryAfter::from_secs(60),
            namespaces: smallvec![],
        }
    }

    fn trace_attachment_item(bytes: usize, parent_id: Option<ParentId>) -> Item {
        let mut item = Item::new(ItemType::Attachment);
        item.set_payload(ContentType::TraceAttachment, "0".repeat(bytes));
        item.set_parent_id(parent_id);
        item
    }

    #[derive(Debug, Default)]
    struct MockLimiter {
        denied: Vec<DataCategory>,
        called: BTreeMap<DataCategory, usize>,
        checked: BTreeSet<DataCategory>,
    }

    impl MockLimiter {
        pub fn deny(mut self, category: DataCategory) -> Self {
            self.denied.push(category);
            self
        }

        pub fn check(&mut self, scoping: ItemScoping, quantity: usize) -> Result<RateLimits, ()> {
            let cat = scoping.category;
            let previous = self.called.insert(cat, quantity);
            assert!(previous.is_none(), "rate limiter invoked twice for {cat}");

            let mut limits = RateLimits::new();
            if self.denied.contains(&cat) {
                limits.add(rate_limit(cat));
            }
            Ok(limits)
        }

        #[track_caller]
        pub fn assert_call(&mut self, category: DataCategory, expected: usize) {
            self.checked.insert(category);

            let quantity = self.called.get(&category).copied();
            assert_eq!(
                quantity,
                Some(expected),
                "Expected quantity `{expected}` for data category `{category}`, got {quantity:?}."
            );
        }
    }

    impl Drop for MockLimiter {
        fn drop(&mut self) {
            if std::thread::panicking() {
                return;
            }

            for checked in &self.checked {
                self.called.remove(checked);
            }

            if self.called.is_empty() {
                return;
            }

            let not_asserted = self
                .called
                .iter()
                .map(|(k, v)| format!("- {k}: {v}"))
                .collect::<Vec<_>>()
                .join("\n");

            panic!("Following calls to the limiter were not asserted:\n{not_asserted}");
        }
    }

    async fn enforce_and_apply(
        mock: Arc<Mutex<MockLimiter>>,
        envelope: Box<Envelope>,
    ) -> (Box<Envelope>, Enforcement, RateLimits) {
        let mut envelope = Managed::from_envelope(envelope, Addr::custom().0);
        let scoping = envelope.scoping();

        #[allow(unused_mut)]
        let mut limiter = EnvelopeLimiter::new(CheckLimits::NonIndexed, move |s, q| {
            let mock = mock.clone();
            async move {
                let mut mock = mock.lock().await;
                mock.check(s, q)
            }
        });

        let (enforcement, limits) = limiter.compute(&envelope, &scoping).await.unwrap();

        // We implemented `clone` only for tests because we don't want to make `apply_with_outcomes`
        // &self because we want move semantics to prevent double tracking.
        enforcement.clone().apply_to_managed(&mut envelope);
        let envelope = envelope.accept(|envelope| envelope);

        (envelope, enforcement, limits)
    }

    fn mock_limiter(categories: &[DataCategory]) -> Arc<Mutex<MockLimiter>> {
        let mut mock = MockLimiter::default();
        for &category in categories {
            mock = mock.deny(category);
        }

        Arc::new(Mutex::new(mock))
    }

    #[tokio::test]
    async fn test_enforce_pass_empty() {
        let envelope = envelope![];

        let mock = mock_limiter(&[]);
        let (envelope, _, limits) = enforce_and_apply(mock, envelope).await;

        assert!(!limits.is_limited());
        assert!(envelope.is_empty());
    }

    #[tokio::test]
    async fn test_enforce_limit_error_event() {
        let envelope = envelope![Event];

        let mock = mock_limiter(&[DataCategory::Error]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert!(envelope.is_empty());
        mock.lock().await.assert_call(DataCategory::Error, 1);
    }

    #[tokio::test]
    async fn test_enforce_limit_error_with_attachments() {
        let envelope = envelope![Event, Attachment];

        let mock = mock_limiter(&[DataCategory::Error]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert!(envelope.is_empty());
        mock.lock().await.assert_call(DataCategory::Error, 1);
    }

    #[tokio::test]
    async fn test_enforce_limit_minidump() {
        let envelope = envelope![Attachment::Minidump];

        let mock = mock_limiter(&[DataCategory::Error]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert!(envelope.is_empty());
        mock.lock().await.assert_call(DataCategory::Error, 1);
    }

    #[tokio::test]
    async fn test_enforce_limit_attachments() {
        let envelope = envelope![Attachment::Minidump, Attachment];

        let mock = mock_limiter(&[DataCategory::Attachment]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        // Attachments would be limited, but crash reports create events and are thus allowed.
        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 1);
        mock.lock().await.assert_call(DataCategory::Error, 1);
        mock.lock().await.assert_call(DataCategory::Attachment, 20);
    }

    /// Limit stand-alone profiles.
    #[tokio::test]
    async fn test_enforce_limit_profiles() {
        let envelope = envelope![Profile, Profile];

        let mock = mock_limiter(&[DataCategory::Profile]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 0);
        mock.lock().await.assert_call(DataCategory::Profile, 2);

        assert_eq!(
            get_outcomes(enforcement),
            vec![
                (DataCategory::Profile, 2),
                (DataCategory::ProfileIndexed, 2)
            ]
        );
    }

    /// Limit profile chunks.
    #[tokio::test]
    async fn test_enforce_limit_profile_chunks_no_profile_type() {
        // In this test we have profile chunks which have not yet been classified, which means they
        // should not be rate limited.
        let envelope = envelope![ProfileChunk, ProfileChunk];

        let mock = mock_limiter(&[DataCategory::ProfileChunk]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;
        assert!(!limits.is_limited());
        assert_eq!(get_outcomes(enforcement), vec![]);

        let mock = mock_limiter(&[DataCategory::ProfileChunkUi]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;
        assert!(!limits.is_limited());
        assert_eq!(get_outcomes(enforcement), vec![]);

        assert_eq!(envelope.len(), 2);
    }

    #[tokio::test]
    async fn test_enforce_limit_profile_chunks_ui() {
        let mut envelope = envelope![];

        let mut item = Item::new(ItemType::ProfileChunk);
        item.set_platform("python".to_owned());
        envelope.add_item(item);
        let mut item = Item::new(ItemType::ProfileChunk);
        item.set_platform("javascript".to_owned());
        envelope.add_item(item);

        let mock = mock_limiter(&[DataCategory::ProfileChunkUi]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 1);
        mock.lock()
            .await
            .assert_call(DataCategory::ProfileChunkUi, 1);
        mock.lock().await.assert_call(DataCategory::ProfileChunk, 1);

        assert_eq!(
            get_outcomes(enforcement),
            vec![(DataCategory::ProfileChunkUi, 1)]
        );
    }

    #[tokio::test]
    async fn test_enforce_limit_profile_chunks_backend() {
        let mut envelope = envelope![];

        let mut item = Item::new(ItemType::ProfileChunk);
        item.set_platform("python".to_owned());
        envelope.add_item(item);
        let mut item = Item::new(ItemType::ProfileChunk);
        item.set_platform("javascript".to_owned());
        envelope.add_item(item);

        let mock = mock_limiter(&[DataCategory::ProfileChunk]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 1);
        mock.lock()
            .await
            .assert_call(DataCategory::ProfileChunkUi, 1);
        mock.lock().await.assert_call(DataCategory::ProfileChunk, 1);

        assert_eq!(
            get_outcomes(enforcement),
            vec![(DataCategory::ProfileChunk, 1)]
        );
    }

    /// Limit replays.
    #[tokio::test]
    async fn test_enforce_limit_replays() {
        let envelope = envelope![ReplayEvent, ReplayRecording, ReplayVideo];

        let mock = mock_limiter(&[DataCategory::Replay]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 0);
        mock.lock().await.assert_call(DataCategory::Replay, 3);

        assert_eq!(get_outcomes(enforcement), vec![(DataCategory::Replay, 3),]);
    }

    /// Limit monitor checkins.
    #[tokio::test]
    async fn test_enforce_limit_monitor_checkins() {
        let envelope = envelope![CheckIn];

        let mock = mock_limiter(&[DataCategory::Monitor]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 0);
        mock.lock().await.assert_call(DataCategory::Monitor, 1);

        assert_eq!(get_outcomes(enforcement), vec![(DataCategory::Monitor, 1)])
    }

    #[tokio::test]
    async fn test_enforce_pass_minidump() {
        let envelope = envelope![Attachment::Minidump];

        let mock = mock_limiter(&[DataCategory::Attachment]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        // If only crash report attachments are present, we don't emit a rate limit.
        assert!(!limits.is_limited());
        assert_eq!(envelope.len(), 1);
        mock.lock().await.assert_call(DataCategory::Error, 1);
        mock.lock().await.assert_call(DataCategory::Attachment, 10);
    }

    #[tokio::test]
    async fn test_enforce_skip_rate_limited() {
        let mut envelope = envelope![];

        let mut item = Item::new(ItemType::Attachment);
        item.set_payload(ContentType::OctetStream, "0123456789");
        item.set_rate_limited(true);
        envelope.add_item(item);

        let mock = mock_limiter(&[DataCategory::Error]);
        let (envelope, _, limits) = enforce_and_apply(mock, envelope).await;

        assert!(!limits.is_limited()); // No new rate limits applied.
        assert_eq!(envelope.len(), 1); // The item was retained
    }

    #[tokio::test]
    async fn test_enforce_pass_sessions() {
        let envelope = envelope![Session, Session, Session];

        let mock = mock_limiter(&[DataCategory::Error]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        // If only crash report attachments are present, we don't emit a rate limit.
        assert!(!limits.is_limited());
        assert_eq!(envelope.len(), 3);
        mock.lock().await.assert_call(DataCategory::Session, 3);
    }

    #[tokio::test]
    async fn test_enforce_limit_sessions() {
        let envelope = envelope![Session, Session, Event];

        let mock = mock_limiter(&[DataCategory::Session]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        // If only crash report attachments are present, we don't emit a rate limit.
        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 1);
        mock.lock().await.assert_call(DataCategory::Error, 1);
        mock.lock().await.assert_call(DataCategory::Session, 2);
    }

    #[tokio::test]
    #[cfg(feature = "processing")]
    async fn test_enforce_limit_assumed_event() {
        let envelope = envelope![Transaction];

        let mock = mock_limiter(&[DataCategory::Transaction]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert!(envelope.is_empty()); // obviously
        mock.lock().await.assert_call(DataCategory::Transaction, 1);
    }

    #[tokio::test]
    #[cfg(feature = "processing")]
    async fn test_enforce_limit_assumed_attachments() {
        let envelope = envelope![Event, Attachment, Attachment];

        let mock = mock_limiter(&[DataCategory::Error]);
        let (envelope, _, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert!(envelope.is_empty());
        mock.lock().await.assert_call(DataCategory::Error, 1);
    }

    #[tokio::test]
    async fn test_enforce_transaction() {
        let envelope = envelope![Transaction];

        let mock = mock_limiter(&[DataCategory::Transaction]);
        let (_, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert!(enforcement.event_indexed.is_active());
        assert!(enforcement.event.is_active());
        mock.lock().await.assert_call(DataCategory::Transaction, 1);

        assert_eq!(
            get_outcomes(enforcement),
            vec![
                (DataCategory::Transaction, 1),
                (DataCategory::TransactionIndexed, 1),
                (DataCategory::Span, 1),
                (DataCategory::SpanIndexed, 1),
            ]
        );
    }

    #[tokio::test]
    async fn test_enforce_transaction_non_indexed() {
        let envelope = envelope![Transaction, Profile];
        let scoping = envelope
            .headers()
            .meta()
            .get_partial_scoping()
            .into_scoping();

        let mock = mock_limiter(&[DataCategory::TransactionIndexed]);

        let mock_clone = mock.clone();
        let limiter = EnvelopeLimiter::new(CheckLimits::NonIndexed, move |s, q| {
            let mock_clone = mock_clone.clone();
            async move {
                let mut mock = mock_clone.lock().await;
                mock.check(s, q)
            }
        });
        let (enforcement, limits) = limiter.compute(&envelope, &scoping).await.unwrap();

        assert!(!limits.is_limited());
        assert!(!enforcement.event_indexed.is_active());
        assert!(!enforcement.event.is_active());
        assert!(!enforcement.profiles_indexed.is_active());
        assert!(!enforcement.profiles.is_active());
        assert!(!enforcement.spans.is_active());
        assert!(!enforcement.spans_indexed.is_active());
        mock.lock().await.assert_call(DataCategory::Transaction, 1);
        mock.lock().await.assert_call(DataCategory::Profile, 1);
        mock.lock().await.assert_call(DataCategory::Span, 1);
    }

    #[tokio::test]
    async fn test_enforce_transaction_no_indexing_quota() {
        let envelope = envelope![Transaction];

        let mock = mock_limiter(&[DataCategory::TransactionIndexed]);
        let (_, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(!limits.is_limited());
        assert!(!enforcement.event_indexed.is_active());
        assert!(!enforcement.event.is_active());
        mock.lock().await.assert_call(DataCategory::Transaction, 1);
        mock.lock().await.assert_call(DataCategory::Span, 1);
    }

    #[tokio::test]
    async fn test_enforce_transaction_attachment_enforced() {
        let envelope = envelope![Transaction, Attachment];

        let mock = mock_limiter(&[DataCategory::Transaction]);
        let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(enforcement.event.is_active());
        assert!(enforcement.attachments_limits.event.is_active());
        mock.lock().await.assert_call(DataCategory::Transaction, 1);
    }

    fn get_outcomes(enforcement: Enforcement) -> Vec<(DataCategory, usize)> {
        enforcement
            .get_outcomes()
            .map(|(_, data_category, quantity)| (data_category, quantity))
            .collect::<Vec<_>>()
    }

    #[tokio::test]
    async fn test_enforce_transaction_profile_enforced() {
        let envelope = envelope![Transaction, Profile];

        let mock = mock_limiter(&[DataCategory::Transaction]);
        let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(enforcement.event.is_active());
        assert!(enforcement.profiles.is_active());
        mock.lock().await.assert_call(DataCategory::Transaction, 1);

        assert_eq!(
            get_outcomes(enforcement),
            vec![
                (DataCategory::Transaction, 1),
                (DataCategory::TransactionIndexed, 1),
                (DataCategory::Profile, 1),
                (DataCategory::ProfileIndexed, 1),
                (DataCategory::Span, 1),
                (DataCategory::SpanIndexed, 1),
            ]
        );
    }

    #[tokio::test]
    async fn test_enforce_transaction_standalone_profile_enforced() {
        // When the transaction is sampled, the profile survives as standalone.
        let envelope = envelope![Profile];

        let mock = mock_limiter(&[DataCategory::Transaction]);
        let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(enforcement.profiles.is_active());
        mock.lock().await.assert_call(DataCategory::Profile, 1);
        mock.lock().await.assert_call(DataCategory::Transaction, 0);

        assert_eq!(
            get_outcomes(enforcement),
            vec![
                (DataCategory::Profile, 1),
                (DataCategory::ProfileIndexed, 1),
            ]
        );
    }

    #[tokio::test]
    async fn test_enforce_transaction_attachment_enforced_indexing_quota() {
        let envelope = envelope![Transaction, Attachment];

        let mock = mock_limiter(&[DataCategory::TransactionIndexed]);
        let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(!enforcement.event.is_active());
        assert!(!enforcement.event_indexed.is_active());
        assert!(!enforcement.attachments_limits.event.is_active());
        mock.lock().await.assert_call(DataCategory::Transaction, 1);
        mock.lock().await.assert_call(DataCategory::Span, 1);
        mock.lock().await.assert_call(DataCategory::Attachment, 10);
        mock.lock()
            .await
            .assert_call(DataCategory::AttachmentItem, 1);

        assert_eq!(get_outcomes(enforcement), vec![]);
    }

    #[tokio::test]
    async fn test_enforce_span() {
        let envelope = envelope![Span, Span];

        let mock = mock_limiter(&[DataCategory::Span]);
        let (_, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert!(enforcement.spans_indexed.is_active());
        assert!(enforcement.spans.is_active());
        mock.lock().await.assert_call(DataCategory::Span, 2);

        assert_eq!(
            get_outcomes(enforcement),
            vec![(DataCategory::Span, 2), (DataCategory::SpanIndexed, 2)]
        );
    }

    #[tokio::test]
    async fn test_enforce_span_no_indexing_quota() {
        let envelope = envelope![Span, Span];

        let mock = mock_limiter(&[DataCategory::SpanIndexed]);
        let (_, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(!limits.is_limited());
        assert!(!enforcement.spans_indexed.is_active());
        assert!(!enforcement.spans.is_active());
        mock.lock().await.assert_call(DataCategory::Span, 2);

        assert_eq!(get_outcomes(enforcement), vec![]);
    }

    #[test]
    fn test_source_quantity_for_total_quantity() {
        let dsn = "https://e12d836b15bb49d7bbf99e64295d995b:@sentry.io/42"
            .parse()
            .unwrap();
        let request_meta = RequestMeta::new(dsn);

        let mut envelope = Envelope::from_request(None, request_meta);

        let mut item = Item::new(ItemType::MetricBuckets);
        item.set_source_quantities(SourceQuantities {
            transactions: 5,
            spans: 0,
            buckets: 5,
        });
        envelope.add_item(item);

        let mut item = Item::new(ItemType::MetricBuckets);
        item.set_source_quantities(SourceQuantities {
            transactions: 2,
            spans: 0,
            buckets: 3,
        });
        envelope.add_item(item);

        let summary = EnvelopeSummary::compute(&envelope);

        assert_eq!(summary.secondary_transaction_quantity, 7);
    }

    #[tokio::test]
    async fn test_enforce_limit_logs_count() {
        let envelope = envelope![Log, Log];

        let mock = mock_limiter(&[DataCategory::LogItem]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 0);
        mock.lock().await.assert_call(DataCategory::LogItem, 2);

        assert_eq!(
            get_outcomes(enforcement),
            vec![(DataCategory::LogItem, 2), (DataCategory::LogByte, 20)]
        );
    }

    #[tokio::test]
    async fn test_enforce_limit_logs_bytes() {
        let envelope = envelope![Log, Log];

        let mock = mock_limiter(&[DataCategory::LogByte]);
        let (envelope, enforcement, limits) = enforce_and_apply(mock.clone(), envelope).await;

        assert!(limits.is_limited());
        assert_eq!(envelope.len(), 0);
        mock.lock().await.assert_call(DataCategory::LogItem, 2);
        mock.lock().await.assert_call(DataCategory::LogByte, 20);

        assert_eq!(
            get_outcomes(enforcement),
            vec![(DataCategory::LogItem, 2), (DataCategory::LogByte, 20)]
        );
    }

    #[tokio::test]
    async fn test_enforce_standalone_span_attachment() {
        let test_cases = &[
            RateLimitTestCase {
                name: "span_limit",
                denied_categories: &[DataCategory::Span],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Span, 0)],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "span_indexed_limit",
                denied_categories: &[DataCategory::SpanIndexed],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Span, 0),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
            RateLimitTestCase {
                name: "attachment_limit",
                denied_categories: &[DataCategory::Attachment],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Span, 0), (DataCategory::Attachment, 7)],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "attachment_indexed_limit",
                denied_categories: &[DataCategory::AttachmentItem],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[
                    (DataCategory::Span, 0),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "transaction_limit",
                denied_categories: &[DataCategory::Transaction],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Span, 0),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
            RateLimitTestCase {
                name: "error_limit",
                denied_categories: &[DataCategory::Error],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Span, 0),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
            RateLimitTestCase {
                name: "no_limits",
                denied_categories: &[],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Span, 0),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
        ];

        for RateLimitTestCase {
            name,
            denied_categories,
            expect_attachment_limit_active,
            expected_limiter_calls,
            expected_outcomes,
        } in test_cases
        {
            let mut envelope = envelope![];
            envelope.add_item(trace_attachment_item(7, Some(ParentId::SpanId(None))));

            let mock = mock_limiter(denied_categories);
            let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

            for &(category, quantity) in *expected_limiter_calls {
                mock.lock().await.assert_call(category, quantity);
            }

            assert_eq!(
                enforcement.attachments_limits.span.bytes.is_active(),
                *expect_attachment_limit_active,
                "{name}: span_attachment byte limit mismatch"
            );
            assert_eq!(
                enforcement.attachments_limits.span.count.is_active(),
                *expect_attachment_limit_active,
                "{name}: span_attachment count limit mismatch"
            );

            assert_eq!(
                get_outcomes(enforcement),
                *expected_outcomes,
                "{name}: outcome mismatch"
            );
        }
    }

    #[tokio::test]
    async fn test_enforce_span_with_span_attachment() {
        let test_cases = &[
            RateLimitTestCase {
                name: "span_limit",
                denied_categories: &[DataCategory::Span, DataCategory::Attachment], // Attachment here has no effect
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Span, 1)],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                    (DataCategory::Span, 1),
                    (DataCategory::SpanIndexed, 1),
                ],
            },
            RateLimitTestCase {
                name: "span_indexed_limit",
                denied_categories: &[DataCategory::SpanIndexed, DataCategory::Attachment],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Span, 1), (DataCategory::Attachment, 7)],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "attachment_limit",
                denied_categories: &[DataCategory::Attachment],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Span, 1), (DataCategory::Attachment, 7)],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "attachment_indexed_limit",
                denied_categories: &[DataCategory::AttachmentItem],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[
                    (DataCategory::Span, 1),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "transaction_limit",
                denied_categories: &[DataCategory::Transaction],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Span, 1),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
            RateLimitTestCase {
                name: "error_limit",
                denied_categories: &[DataCategory::Error],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Span, 1),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
            RateLimitTestCase {
                name: "no_limits",
                denied_categories: &[],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Span, 1),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
        ];

        for RateLimitTestCase {
            name,
            denied_categories,
            expect_attachment_limit_active,
            expected_limiter_calls,
            expected_outcomes,
        } in test_cases
        {
            let mut envelope = envelope![Span];
            envelope.add_item(trace_attachment_item(7, Some(ParentId::SpanId(None))));

            let mock = mock_limiter(denied_categories);
            let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

            for &(category, quantity) in *expected_limiter_calls {
                mock.lock().await.assert_call(category, quantity);
            }

            assert_eq!(
                enforcement.attachments_limits.span.bytes.is_active(),
                *expect_attachment_limit_active,
                "{name}: span_attachment byte limit mismatch"
            );
            assert_eq!(
                enforcement.attachments_limits.span.count.is_active(),
                *expect_attachment_limit_active,
                "{name}: span_attachment count limit mismatch"
            );

            assert_eq!(
                get_outcomes(enforcement),
                *expected_outcomes,
                "{name}: outcome mismatch"
            );
        }
    }

    #[tokio::test]
    async fn test_enforce_transaction_span_attachment() {
        let test_cases = &[
            RateLimitTestCase {
                name: "transaction_limit",
                denied_categories: &[DataCategory::Transaction],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Transaction, 1)],
                expected_outcomes: &[
                    (DataCategory::Transaction, 1),
                    (DataCategory::TransactionIndexed, 1),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                    (DataCategory::Span, 1),
                    (DataCategory::SpanIndexed, 1),
                ],
            },
            RateLimitTestCase {
                name: "error_limit",
                denied_categories: &[DataCategory::Error],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Transaction, 1),
                    (DataCategory::Span, 1),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
            RateLimitTestCase {
                name: "no_limits",
                denied_categories: &[],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Transaction, 1),
                    (DataCategory::Span, 1),
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
        ];

        for RateLimitTestCase {
            name,
            denied_categories,
            expect_attachment_limit_active,
            expected_limiter_calls,
            expected_outcomes,
        } in test_cases
        {
            let mut envelope = envelope![Transaction];
            envelope.add_item(trace_attachment_item(7, Some(ParentId::SpanId(None))));

            let mock = mock_limiter(denied_categories);
            let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

            for &(category, quantity) in *expected_limiter_calls {
                mock.lock().await.assert_call(category, quantity);
            }

            assert_eq!(
                enforcement.attachments_limits.span.bytes.is_active(),
                *expect_attachment_limit_active,
                "{name}: span_attachment byte limit mismatch"
            );
            assert_eq!(
                enforcement.attachments_limits.span.count.is_active(),
                *expect_attachment_limit_active,
                "{name}: span_attachment count limit mismatch"
            );

            assert_eq!(
                get_outcomes(enforcement),
                *expected_outcomes,
                "{name}: outcome mismatch"
            );
        }
    }

    #[tokio::test]
    async fn test_enforce_standalone_trace_attachment() {
        let test_cases = &[
            RateLimitTestCase {
                name: "attachment_limit",
                denied_categories: &[DataCategory::Attachment],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Attachment, 7)],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "attachment_limit_and_attachment_item_limit",
                denied_categories: &[DataCategory::Attachment, DataCategory::AttachmentItem],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[(DataCategory::Attachment, 7)],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "attachment_item_limit",
                denied_categories: &[DataCategory::AttachmentItem],
                expect_attachment_limit_active: true,
                expected_limiter_calls: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
            },
            RateLimitTestCase {
                name: "no_limits",
                denied_categories: &[],
                expect_attachment_limit_active: false,
                expected_limiter_calls: &[
                    (DataCategory::Attachment, 7),
                    (DataCategory::AttachmentItem, 1),
                ],
                expected_outcomes: &[],
            },
        ];

        for RateLimitTestCase {
            name,
            denied_categories,
            expect_attachment_limit_active,
            expected_limiter_calls,
            expected_outcomes,
        } in test_cases
        {
            let mut envelope = envelope![];
            envelope.add_item(trace_attachment_item(7, None));

            let mock = mock_limiter(denied_categories);
            let (_, enforcement, _) = enforce_and_apply(mock.clone(), envelope).await;

            for &(category, quantity) in *expected_limiter_calls {
                mock.lock().await.assert_call(category, quantity);
            }

            assert_eq!(
                enforcement.attachments_limits.trace.bytes.is_active(),
                *expect_attachment_limit_active,
                "{name}: trace_attachment byte limit mismatch"
            );
            assert_eq!(
                enforcement.attachments_limits.trace.count.is_active(),
                *expect_attachment_limit_active,
                "{name}: trace_attachment count limit mismatch"
            );

            assert_eq!(
                get_outcomes(enforcement),
                *expected_outcomes,
                "{name}: outcome mismatch"
            );
        }
    }
}