1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
use std::hash::Hasher as _;
use hash32::{FnvHasher, Hasher as _};
#[doc(inline)]
pub use relay_base_schema::metrics::{
CustomUnit, DurationUnit, FractionUnit, InformationUnit, MetricName, MetricNamespace,
MetricResourceIdentifier, MetricType, MetricUnit, ParseMetricError, ParseMetricUnitError,
};
#[doc(inline)]
pub use relay_common::time::UnixTimestamp;
#[doc(inline)]
pub use unescaper::Error as UnescapeError;
use crate::{Bucket, FiniteF64, MetricTags};
/// Type used for Counter metric
pub type CounterType = FiniteF64;
/// Type of distribution entries
pub type DistributionType = FiniteF64;
/// Type used for set elements in Set metric
pub type SetType = u32;
/// Type used for Gauge entries
pub type GaugeType = FiniteF64;
/// Error returned from [`normalize_bucket`].
#[derive(Debug, thiserror::Error)]
pub enum NormalizationError {
/// The metric name includes an invalid or unsupported metric namespace.
#[error("unsupported metric namespace")]
UnsupportedNamespace,
/// The metric name cannot be parsed and is invalid.
#[error("invalid metric name: {0:?}")]
InvalidMetricName(MetricName),
}
/// Normalizes a bucket.
///
/// The passed metric will have its name and tags normalized and tested for validity.
/// Invalid characters in the metric name may be replaced,
/// see [`relay_base_schema::metrics::try_normalize_metric_name`].
///
/// Invalid tags are removed and tag keys are normalized, for example control characters are
/// removed from tag keys.
pub fn normalize_bucket(bucket: &mut Bucket) -> Result<(), NormalizationError> {
normalize_metric_name(&mut bucket.name)?;
normalize_metric_tags(&mut bucket.tags);
Ok(())
}
/// Normalizes a metric name.
///
/// Normalization includes expanding valid metric names without a namespace to the default
/// namespace.
///
/// Invalid metric names are rejected with [`NormalizationError`].
fn normalize_metric_name(name: &mut MetricName) -> Result<(), NormalizationError> {
*name = match MetricResourceIdentifier::parse(name) {
Ok(mri) => {
if matches!(mri.namespace, MetricNamespace::Unsupported) {
return Err(NormalizationError::UnsupportedNamespace);
}
// We can improve this code part, by not always re-creating the name, if the name is
// already a valid MRI with namespace we can use the original name instead.
mri.to_string().into()
}
Err(_) => {
return Err(NormalizationError::InvalidMetricName(name.clone()));
}
};
Ok(())
}
/// Removes tags with invalid characters in the key, and validates tag values.
///
/// Tag values are validated with [`normalize_tag_value`].
fn normalize_metric_tags(tags: &mut MetricTags) {
tags.retain(|tag_key, tag_value| {
if !is_valid_tag_key(tag_key) {
relay_log::debug!("invalid metric tag key {tag_key:?}");
return false;
}
normalize_tag_value(tag_value);
true
});
}
/// Validates a tag key.
///
/// Tag keys currently only need to not contain ASCII control characters. This might change.
pub(crate) fn is_valid_tag_key(tag_key: &str) -> bool {
// iterating over bytes produces better asm, and we're only checking for ascii chars
for &byte in tag_key.as_bytes() {
if (byte as char).is_ascii_control() {
return false;
}
}
true
}
/// Replaces restricted characters with escape sequences.
///
/// All other characters are replaced with the following rules:
/// - Tab is escaped as `\t`.
/// - Carriage return is escaped as `\r`.
/// - Line feed is escaped as `\n`.
/// - Backslash is escaped as `\\`.
/// - Commas and pipes are given unicode escapes in the form `\u{2c}` and `\u{7c}`, respectively.
#[allow(unused)]
pub(crate) fn escape_tag_value(raw: &str) -> String {
let mut escaped = String::with_capacity(raw.len());
for c in raw.chars() {
match c {
'\t' => escaped.push_str("\\t"),
'\n' => escaped.push_str("\\n"),
'\r' => escaped.push_str("\\r"),
'\\' => escaped.push_str("\\\\"),
'|' => escaped.push_str("\\u{7c}"),
',' => escaped.push_str("\\u{2c}"),
_ if c.is_control() => (),
_ => escaped.push(c),
}
}
escaped
}
/// Decodes and normalizes a potentially escaped tag value into a raw string.
///
/// This replaces escape sequences following the rules of [`escape_tag_value`] with their original
/// unicode characters. In addition to that, unicode escape sequences for all characters will be
/// resolved.
///
/// Control characters are stripped from the resulting string. This is equivalent to
/// [`normalize_tag_value`].
pub(crate) fn unescape_tag_value(escaped: &str) -> Result<String, UnescapeError> {
let mut unescaped = unescaper::unescape(escaped)?;
normalize_tag_value(&mut unescaped);
Ok(unescaped)
}
/// Normalizes a tag value.
///
/// Tag values are never entirely rejected, but invalid characters (control characters) are stripped
/// out.
pub(crate) fn normalize_tag_value(tag_value: &mut String) {
tag_value.retain(|c| !c.is_control());
}
/// Hashes the given set value.
///
/// Sets only guarantee 32-bit accuracy, but arbitrary strings are allowed on the protocol. Upon
/// parsing, they are hashed and only used as hashes subsequently.
pub(crate) fn hash_set_value(string: &str) -> u32 {
let mut hasher = FnvHasher::default();
hasher.write(string.as_bytes());
hasher.finish32()
}
#[cfg(test)]
mod tests {
use insta::assert_json_snapshot;
use crate::BucketValue;
use super::*;
#[test]
fn test_unescape_tag_value() {
// No escaping
assert_eq!(unescape_tag_value("plain").unwrap(), "plain");
assert_eq!(unescape_tag_value("plain text").unwrap(), "plain text");
assert_eq!(unescape_tag_value("plain%text").unwrap(), "plain%text");
// Escape sequences
assert_eq!(
unescape_tag_value("plain \\\\ text").unwrap(),
"plain \\ text"
);
assert_eq!(
unescape_tag_value("plain\\u{2c}text").unwrap(),
"plain,text"
);
assert_eq!(
unescape_tag_value("plain\\u{7c}text").unwrap(),
"plain|text"
);
assert_eq!(unescape_tag_value("plain 😅").unwrap(), "plain 😅");
// Alternate escape sequences
assert_eq!(
unescape_tag_value("plain \\u{5c} text").unwrap(),
"plain \\ text"
);
// These are control characters and therefore stripped
assert_eq!(unescape_tag_value("plain\\ntext").unwrap(), "plaintext");
assert_eq!(unescape_tag_value("plain\\rtext").unwrap(), "plaintext");
assert_eq!(unescape_tag_value("plain\\ttext").unwrap(), "plaintext");
assert_eq!(unescape_tag_value("plain\u{7}text").unwrap(), "plaintext");
}
#[test]
fn test_escape_tag_value() {
// No escaping
assert_eq!(escape_tag_value("plain"), "plain");
assert_eq!(escape_tag_value("plain text"), "plain text");
assert_eq!(escape_tag_value("plain%text"), "plain%text");
// Escape sequences
assert_eq!(escape_tag_value("plain \\ text"), "plain \\\\ text");
assert_eq!(escape_tag_value("plain,text"), "plain\\u{2c}text");
assert_eq!(escape_tag_value("plain|text"), "plain\\u{7c}text");
assert_eq!(escape_tag_value("plain 😅"), "plain 😅");
// Escapable control characters (may be stripped by the parser)
assert_eq!(escape_tag_value("plain\ntext"), "plain\\ntext");
assert_eq!(escape_tag_value("plain\rtext"), "plain\\rtext");
assert_eq!(escape_tag_value("plain\ttext"), "plain\\ttext");
// Unescapable control characters
assert_eq!(escape_tag_value("plain\u{07}text"), "plaintext");
assert_eq!(escape_tag_value("plain\u{9c}text"), "plaintext");
}
#[test]
fn test_normalize_invalid_name() {
let mut bucket = Bucket {
timestamp: UnixTimestamp::from_secs(5000),
width: 0,
name: "c:transactions/\0hergus.bergus@none".into(),
value: BucketValue::Counter(0.into()),
tags: Default::default(),
metadata: Default::default(),
};
assert!(matches!(
normalize_bucket(&mut bucket),
Err(NormalizationError::InvalidMetricName(_))
));
}
#[test]
fn test_normalize_invalid_namespace() {
let mut bucket = Bucket {
timestamp: UnixTimestamp::from_secs(5000),
width: 0,
name: "c:lol/hergus.bergus@none".into(),
value: BucketValue::Counter(0.into()),
tags: Default::default(),
metadata: Default::default(),
};
assert!(matches!(
normalize_bucket(&mut bucket),
Err(NormalizationError::UnsupportedNamespace)
));
}
#[test]
fn test_normalize_name() {
let mut bucket = Bucket {
timestamp: UnixTimestamp::from_secs(5000),
width: 0,
name: "c:hergus\0\0bergus".into(),
value: BucketValue::Counter(0.into()),
tags: Default::default(),
metadata: Default::default(),
};
normalize_bucket(&mut bucket).unwrap();
assert_eq!(&bucket.name, "c:custom/hergus_bergus@none");
}
#[test]
fn test_normalize_tag_key_chars() {
let mut bucket = Bucket {
timestamp: UnixTimestamp::from_secs(5000),
width: 0,
name: "c:transactions/hergus.bergus".into(),
value: BucketValue::Counter(0.into()),
tags: {
let mut tags = MetricTags::new();
// There are some SDKs which mess up content encodings, and interpret the raw bytes
// of an UTF-16 string as UTF-8. Leading to ASCII
// strings getting null-bytes interleaved.
//
// Somehow those values end up as release tag in sessions, while in error events we
// haven't observed this malformed encoding. We believe it's slightly better to
// strip out NUL-bytes instead of dropping the tag such that those values line up
// again across sessions and events. Should that cause too high cardinality we'll
// have to drop tags.
//
// Note that releases are validated separately against much stricter character set,
// but the above idea should still apply to other tags.
tags.insert(
"is_it_garbage".to_owned(),
"a\0b\0s\0o\0l\0u\0t\0e\0l\0y".to_owned(),
);
tags.insert("another\0garbage".to_owned(), "bye".to_owned());
tags
},
metadata: Default::default(),
};
normalize_bucket(&mut bucket).unwrap();
assert_json_snapshot!(bucket, @r###"
{
"timestamp": 5000,
"width": 0,
"name": "c:transactions/hergus.bergus@none",
"type": "c",
"value": 0.0,
"tags": {
"is_it_garbage": "absolutely"
}
}
"###);
}
}